This repository was archived by the owner on Jul 9, 2025. It is now read-only.
fix: unify runtime path from ejecting #6520
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lei9444
requested review from
GeoffCoxMSFT,
a-b-r-o-w-n,
beyackle,
boydc2014,
cwhitten,
hatpick,
srinaath and
tonyanziano
as code owners
boydc2014
approved these changes
Mar 23, 2021
|
Thanks, this was helpful. Thanks |
cwhitten
pushed a commit
that referenced
this pull request
Mar 31, 2021
Co-authored-by: Dong Lei <donglei@microsoft.com>
Merged
benbrown
pushed a commit
to benbrown/BotFramework-Composer
that referenced
this pull request
May 24, 2021
Co-authored-by: Dong Lei <donglei@microsoft.com>
benbrown
pushed a commit
that referenced
this pull request
Jun 11, 2021
Co-authored-by: Dong Lei <donglei@microsoft.com>
lei9444
added a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
Co-authored-by: Dong Lei <donglei@microsoft.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
issue
in 1.3.1 the eject runtime path is the relative path for the bot folder.
But in 1.4.0 the path is the relative path for the bot/settings.
So the bot created by 1.3.1 with custom runtime can't work.
fix
make the 1.3.1 and 1.4.0 use the same runtime path when do eject.
if the runtime is new runtime, still use the relative path for the bot/settings.
Task Item
#minor
closes #6519
Screenshots